Re: [PATCH v2 3/4] KVM: arm/arm64: Move to common kvm_mmu_memcache infrastructure

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH v2 3/4] KVM: arm/arm64: Move to common kvm_mmu_memcache infrastructure
From: Paolo Bonzini <pbonzini@xxxxxxxxxx>
Date: Fri, 15 Mar 2019 18:36:19 +0100
Cc: kvmarm@xxxxxxxxxxxxxxxxxxxxx, James Hogan <jhogan@xxxxxxxxxx>, Radim Krčmář <rkrcmar@xxxxxxxxxx>, Joerg Roedel <joro@xxxxxxxxxx>, Marc Zyngier <marc.zyngier@xxxxxxx>, Paul Mackerras <paulus@xxxxxxxxxx>, Christian Borntraeger <borntraeger@xxxxxxxxxx>, Anshuman Khandual <anshuman.khandual@xxxxxxx>, Suzuki K Poulose <Suzuki.Poulose@xxxxxxx>, Sean Christopherson <sean.j.christopherson@xxxxxxxxx>
In-reply-to: <20190131095244.7480-4-christoffer.dall@arm.com>
Openpgp: preference=signencrypt
References: <20190131095244.7480-1-christoffer.dall@arm.com> <20190131095244.7480-4-christoffer.dall@arm.com>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0

On 31/01/19 10:52, Christoffer Dall wrote:
> +#define KVM_MMU_CACHE_GFP	GFP_KERNEL
> +#define KVM_MMU_CACHE_PAGE_GFP	(GFP_KERNEL | __GFP_ZERO)

This should be GFP_KERNEL_ACCOUNT.  Can you leave GFP_KERNEL_ACCOUNT in
virt/kvm/kvm_main.c, and only use these #defines to add __GFP_ZERO?  I
don't think anyone should be using GFP_ATOMIC for instance.

Paolo

References:
- [PATCH v2 0/3] KVM: Unify mmu_memory_cache functionality across architectures
  - From: Christoffer Dall
- [PATCH v2 3/4] KVM: arm/arm64: Move to common kvm_mmu_memcache infrastructure
  - From: Christoffer Dall

Prev by Date: Re: [PATCH] kvm: x86: Return LA57 feature based on hardware capability
Next by Date: Re: [PATCH v2 0/3] KVM: Unify mmu_memory_cache functionality across architectures
Previous by thread: [PATCH v2 3/4] KVM: arm/arm64: Move to common kvm_mmu_memcache infrastructure
Next by thread: [PATCH v2 4/4] KVM: mips: Move to common kvm_mmu_memcache infrastructure
Index(es):
- Date
- Thread

[Index of Archives] [KVM ARM] [KVM ia64] [KVM ppc] [Virtualization Tools] [Spice Development] [Libvirt] [Libvirt Users] [Linux USB Devel] [Linux Audio Users] [Yosemite Questions] [Linux Kernel] [Linux SCSI] [XFree86]