Re: [PATCH v5 6/6] VT-d: support the device IOTLB

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2009-05-18 at 13:51 +0800, Yu Zhao wrote:
> 
> @@ -965,6 +1037,8 @@ static void iommu_flush_iotlb_psi(struct intel_iommu *iommu, u16 did,
>         else
>                 iommu->flush.flush_iotlb(iommu, did, addr, mask,
>                                                 DMA_TLB_PSI_FLUSH);
> +       if (did)
> +               iommu_flush_dev_iotlb(iommu->domains[did], addr, mask);
>  }
>  
>  static void iommu_disable_protect_mem_regions(struct intel_iommu *iommu)

Hm, why 'if (did)' ? 

Domain ID zero is only special in caching mode. Should it be:
	if (!cap_caching_mode(iommu->cap) || did)
?

Either way, it wants a comment.

-- 
David Woodhouse                            Open Source Technology Centre
David.Woodhouse@xxxxxxxxx                              Intel Corporation

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux