Sean Christopherson <sean.j.christopherson@xxxxxxxxx> writes: > On Mon, Mar 11, 2019 at 12:56:33PM +0100, Vitaly Kuznetsov wrote: >> Sean Christopherson <sean.j.christopherson@xxxxxxxxx> writes: >> >> > + unsigned gpte_size:1; >> >> This is probably just a matter of taste but I would prefer it to be >> renamed to something like "gpte_is_64": when I see >> >> role.gpte_size = true >> >> I have to go and read the definition if gpte_size, >> >> role.gpte_is_64 = true >> >> reads more naturally. > > Agreed. What about gpte_is_8_bytes to avoid being misconstrued as "this > gpte is for paging in 64-bit mode"? > Even better! -- Vitaly
