Re: [PATCH 1/2] KVM: Implement kvm_copy_guest() to perform copy of guest memory in place

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Suraj,

I love your patch! Yet something to improve:

[auto build test ERROR on kvm/linux-next]
[also build test ERROR on v5.0 next-20190305]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Suraj-Jitindar-Singh/KVM-Implement-kvm_copy_guest-to-perform-copy-of-guest-memory-in-place/20190306-170132
base:   https://git.kernel.org/pub/scm/virt/kvm/kvm.git linux-next
config: i386-randconfig-l2-03061123 (attached as .config)
compiler: gcc-5 (Debian 5.5.0-3) 5.4.1 20171010
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All errors (new ones prefixed by >>):

   arch/x86/kvm/../../../virt/kvm/kvm_main.c: In function '__kvm_copy_guest_page':
>> arch/x86/kvm/../../../virt/kvm/kvm_main.c:2018:6: error: implicit declaration of function 'raw_copy_in_user' [-Werror=implicit-function-declaration]
     r = raw_copy_in_user((void __user *)to_addr + to_offset,
         ^
   cc1: some warnings being treated as errors

vim +/raw_copy_in_user +2018 arch/x86/kvm/../../../virt/kvm/kvm_main.c

  2003	
  2004	static int __kvm_copy_guest_page(struct kvm_memory_slot *to_memslot,
  2005					 gfn_t to_gfn, int to_offset,
  2006					 struct kvm_memory_slot *from_memslot,
  2007					 gfn_t from_gfn, int from_offset, int len)
  2008	{
  2009		int r;
  2010		unsigned long to_addr, from_addr;
  2011	
  2012		to_addr = gfn_to_hva_memslot(to_memslot, to_gfn);
  2013		if (kvm_is_error_hva(to_addr))
  2014			return -EFAULT;
  2015		from_addr = gfn_to_hva_memslot(from_memslot, from_gfn);
  2016		if (kvm_is_error_hva(from_addr))
  2017			return -EFAULT;
> 2018		r = raw_copy_in_user((void __user *)to_addr + to_offset,
  2019				     (void __user *)from_addr + from_offset, len);
  2020		if (r)
  2021			return -EFAULT;
  2022		mark_page_dirty_in_slot(to_memslot, to_gfn);
  2023		return 0;
  2024	}
  2025	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux