On Sun, Jun 28, 2009 at 12:29:26PM +0300, Avi Kivity wrote: > On 06/25/2009 03:21 PM, Gleb Natapov wrote: >> Signed-off-by: Gleb Natapov<gleb@xxxxxxxxxx> >> > > Why is it needed? (good changelog material). > OK. >> } >> - >> + >> + kvm_set_boot_cpu_id(0); >> > > You're not testing for failure. Doesn't matter here because it's the > default, but then you can omit the call entirely. > This is a place holder. The patch adds an interface but doesn't add any user if this line is omitted. As you said there is no need to check for failure in this case, if we do we will not be able to run on older kernels. -- Gleb. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html