On 22/02/19 01:30, Sean Christopherson wrote: > On Thu, Feb 21, 2019 at 08:56:06PM +0000, Joao Martins wrote: >> The Xen addition follows the same structure as Hyper-V in kvm (what you suggest >> here is probably applicable for both). i.e. there's some Xen specific routines >> for vm/vcpu init/teardown, and timer handling. We would have to place some of >> those functions into a struct that gets registered at modinit. > > Huh. I never really hooked at the Hyper-V code, for some reason I always > assumed it was only related to running KVM on Hyper-V. I agree that this > extra hurdle only makes sense if it's also applied to Hyper-V. The difference is that Hyper-V support is more or less mandatory to run recent Windows guests. Having a config symbol would be enough for me. Paolo