On Fri, Feb 08, 2019 at 03:41:55PM -0500, Nitesh Narayan Lal wrote: > >> I am also planning to try Michael's suggestion of using MAX_ORDER - 1. > >> However I am still thinking about a workload which I can use to test its > >> effectiveness. > > You might want to look at doing something like min(MAX_ORDER - 1, > > HUGETLB_PAGE_ORDER). I know for x86 a 2MB page is the upper limit for > > THP which is the most likely to be used page size with the guest. > Sure, thanks for the suggestion. Given current hinting in balloon is MAX_ORDER I'd say share code. If you feel a need to adjust down the road, adjust both of them with actual testing showing gains. -- MST