On 2/1/19 12:20 PM, Sean Christopherson wrote: > On Fri, Feb 01, 2019 at 04:47:12PM +0000, Singh, Brijesh wrote: >> svm.c is pretty huge, before we add more SEV specific commands (e.g SEV-ES, >> SEV-Migration etc) lets move the SEV command handling into a separate file. >> There is no logical changes in this series. > > Any reason not to create arch/x86/kvm/svm/ before introducing sev.c? > There are several features in svm.c that can be moved to different files, SEV bits are just the start. I was thinking that we create svm directory after features are separated in different files rather than creating the directory first. Having said so, I am not oppose to creating directory first then moving the code in a separate file. Paolo, Radim thoughts ? thanks