On Mon, 4 Feb 2019 10:59:41 +0100 Anisse Astier <aastier@xxxxxxxxxx> wrote: > Hi, > > This patch series fixes a few warnings when building kvmtool with > GCC8. I'm not sure it's the best solution for each case. Ah, thanks, I was just about to come back to this. So I installed x86->arm64 and arm64->x86 cross compilers from the vanilla FSF GCC 8.2 sources, and could reproduce the warnings/errors, plus can confirm the fixes. However my toolchain complained about more issues, which I fixed in three more patches on top of this. I will send them out in a minute. Out of curiosity, what was your compiler version / build? Did your distro disable some warnings during build time? Cheers, Andre. > Note that kvmtool was removed from Debian testing following these > warnings (but it's using an old version): > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=897777 > > I do not know why it wasn't built with WERROR=0 instead. > > Changes since v1: > - series rebased on master > - patch 1: fixed snprintf size thanks to Will's review > - patch 2: added another similar warning fix in the same file > - patch 3: errno isn't touched anymore (thanks Will) > > @Andre: I did not pick up your Reviewed-by for patch 2 since it was > modified afterwards. > > Regards, > > Anisse > > -- > Anisse Astier (3): > builtin-run: Fix warning when resolving path > virtio: fix warning on strncpy > kvmtool: 9p: fix overapping snprintf > > builtin-run.c | 4 +++- > virtio/9p.c | 9 ++++++++- > virtio/net.c | 6 +++--- > 3 files changed, 14 insertions(+), 5 deletions(-) >
