Re: [PATCH kvmtool] init: fix sysfs mount arguments

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Will Deacon <will.deacon@xxxxxxx> writes:

> Hi Dmitry,
>
> On Thu, Jan 17, 2019 at 11:45:00AM +0000, Dmitry Monakhov wrote:
>> From: Dmitry Monakhov <dmtrmonakhov@xxxxxxxxxxxxxx>
>> 
>> It is not good idea to pass empty 'source' argument to  mount(2) because libmount complains about
>> incorrect /proc/self/mountinfo structure. This affect many applications such as findmnt, umount and etc.
>> Let's add fake source argument to sysfs mount command as we do with all other filesystems.
>> 
>> #TESTCASE_BEGIN:
>> ## findmount will complain like this 'findmnt: /proc/self/mountinfo: parse error at line 4 -- ignored'
>> echo "/bin/findmnt" > ./test.sh
>> ./lkvm setup init-mount-test
>> ./lkvm run -d init-mount-test --sandbox test.sh
>> rm -rf ~/.lkvm/init-mount-test
>> #TESTCASE_END
>> ---
>>  guest/init.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> Please can I have your Signed-off-by so that I can merge this?
Definitely yes. Thank you.
>
> Thanks,
>
> Will



[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux