On 30/01/2019 18:20, Will Deacon wrote: > On Fri, Jan 25, 2019 at 03:43:08PM +0000, Andre Przywara wrote: >> When loading a firmware instead of a kernel, we can still pass on any >> *user-provided* command line, as /chosen/bootargs is a generic device tree >> feature. We just need to make sure to not pass our mangled-for-Linux >> version. >> >> This allows to run "firmware" images which make use of a command line, >> still are not Linux kernels, like kvm-unit-tests. >> >> Signed-off-by: Andre Przywara <andre.przywara@xxxxxxx> >> --- >> Hi Will, >> >> this goes on top of Julien's firmware series (which did not yet appear >> on kernel.org?) >> This fixes an issue with some kvm-unit-tests support. [1] > > Does kvm-unit-tests break if we pass the modified command line? I'm wary of > passing something different depending on whether the payload is firmware or > kernel, because there's a pretty fine line between the two (and the firmware > may even just forward the thing on to the kernel it loads). > Yes, this is why I removed it initially for the firmware case. In the EFI case, the DT is just passed as is to Linux, however the Linux EFI stub retrieves the command line from EFI, and the command line in the DT is ignored. So to avoid confusion, I wanted to prevent passing a command line that just gets ignored. However the command line property of the chosen node is not linux specific and some other OS/firmware/bootloader could rely on it. So I'm not sure what's the best move here. Cheers, -- Julien Thierry
