On Wed, 30 Jan 2019 18:09:31 +0100 Halil Pasic <pasic@xxxxxxxxxxxxx> wrote: > On Wed, 30 Jan 2019 14:22:12 +0100 > Cornelia Huck <cohuck@xxxxxxxxxx> wrote: > > > +static void fsm_async_retry(struct vfio_ccw_private *private, > > + enum vfio_ccw_event event) > > +{ > > + private->cmd_region->ret_code = -EAGAIN; > > +} > > + > > This is essentially dead code at the moment, isn't it? I mean we hold the > io_mutex whenever we are in state VFIO_CCW_STATE_CP_PROCESSING, and we > call vfio_ccw_fsm_event() with the very same mutex held. Well, I did have to put something in the state machine...