On 1/24/19 1:07 PM, Andrew Jones wrote: > On Thu, Jan 24, 2019 at 11:16:34AM +0000, Alexandru Elisei wrote: >> Instead of aborting the test when an unexpected parameter is found, use >> argv_find() to search for the desired parameter. On arm and arm64, this >> allows kvm-unit-tests to be used with virtual machine monitors like kvmtool >> which automatically adds parameters to the kernel command line. >> >> For example, to run the gicv3-ipi test the following command was used: >> >> lkvm run -k gic.flat -c 8 -m 410 -p "ipi" --irqchip=gicv3 >> >> The resulting kernel command line that was passed to kvm-unit-tests was: >> >> "console=ttyS0 rw rootflags=trans=virtio,version=9p2000.L,cache=loose rootfstype=9p init=/virt/init ip=dhcp ipi" > Why not write a patch for kvmtool that provides a new command line > parameter which says to not add any kernel parameters other than what > is provided with '-p'? Giving the user full control over the kernel > command line seems like a feature kvmtool would want anyway. > > Thanks, > drew A patch to remove the kvmtool kernel command line has been posted [1]. I will drop patches 6 and 7, thank you for the feedback. [1] https://www.spinics.net/lists/kvm/msg181009.html
