On Wed, Jan 16, 2019 at 08:11:44PM +0100, Gerald Schaefer wrote: > Commit 9d3a4de4cb8d ("iommu: Disambiguate MSI region types") changed > the reserved region type in intel_iommu_get_resv_regions() from > IOMMU_RESV_RESERVED to IOMMU_RESV_MSI, but it forgot to also change > the type in intel_iommu_put_resv_regions(). > > This leads to a memory leak, because now the check in > intel_iommu_put_resv_regions() for IOMMU_RESV_RESERVED will never > be true, and no allocated regions will be freed. > > Fix this by changing the region type in intel_iommu_put_resv_regions() > to IOMMU_RESV_MSI, matching the type of the allocated regions. > > Fixes: 9d3a4de4cb8d ("iommu: Disambiguate MSI region types") > Cc: <stable@xxxxxxxxxxxxxxx> # v4.11+ > Signed-off-by: Gerald Schaefer <gerald.schaefer@xxxxxxxxxx> > --- > drivers/iommu/intel-iommu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied, thanks.