On Thu, 10 Jan 2019 14:20:44 +0000
Julien Thierry <julien.thierry@xxxxxxx> wrote:
Hi,
> Implement firmware image loading for arm and set the boot start
> address to the firmware address.
>
> Add an option for the user to specify where to map the firmware.
Many thanks for making this optional!
> Signed-off-by: Julien Thierry <julien.thierry@xxxxxxx>
> ---
> arm/fdt.c | 14 +++++++-
> arm/include/arm-common/kvm-config-arch.h | 5 ++-
> arm/kvm.c | 61
> +++++++++++++++++++++++++++++++- 3 files changed, 77 insertions(+), 3
> deletions(-)
>
> diff --git a/arm/fdt.c b/arm/fdt.c
> index 664bb62..2936986 100644
> --- a/arm/fdt.c
> +++ b/arm/fdt.c
> @@ -131,7 +131,19 @@ static int setup_fdt(struct kvm *kvm)
> /* /chosen */
> _FDT(fdt_begin_node(fdt, "chosen"));
> _FDT(fdt_property_cell(fdt, "linux,pci-probe-only", 1));
> - _FDT(fdt_property_string(fdt, "bootargs",
> kvm->cfg.real_cmdline)); +
> + if (kvm->cfg.firmware_filename) {
> + /*
> + * When using a firmware, command line is not passed
> through DT,
> + * or the firmware can add it itself
> + */
> + if (kvm->cfg.kernel_cmdline)
> + pr_warning("Ignoring custom bootargs: %s\n",
> + kvm->cfg.kernel_cmdline);
> + } else
> + _FDT(fdt_property_string(fdt, "bootargs",
> + kvm->cfg.real_cmdline));
> +
> _FDT(fdt_property_u64(fdt, "kaslr-seed",
> kvm->cfg.arch.kaslr_seed));
> /* Initrd */
> diff --git a/arm/include/arm-common/kvm-config-arch.h
> b/arm/include/arm-common/kvm-config-arch.h index 6a196f1..5734c46
> 100644 --- a/arm/include/arm-common/kvm-config-arch.h
> +++ b/arm/include/arm-common/kvm-config-arch.h
> @@ -11,6 +11,7 @@ struct kvm_config_arch {
> bool has_pmuv3;
> u64 kaslr_seed;
> enum irqchip_type irqchip;
> + u64 fw_addr;
> };
>
> int irqchip_parser(const struct option *opt, const char *arg, int
> unset); @@ -30,6 +31,8 @@ int irqchip_parser(const struct option
> *opt, const char *arg, int unset); OPT_CALLBACK('\0', "irqchip",
> &(cfg)->irqchip, \
> "[gicv2|gicv2m|gicv3|gicv3-its]", \
> "Type of interrupt controller to emulate in the guest", \
> - irqchip_parser, NULL),
> + irqchip_parser,
> NULL), \
> + OPT_U64('\0', "firmware-address",
> &(cfg)->fw_addr, \
> + "Address where firmware should be loaded"),
>
> #endif /* ARM_COMMON__KVM_CONFIG_ARCH_H */
> diff --git a/arm/kvm.c b/arm/kvm.c
> index c6843e5..d3f8f5d 100644
> --- a/arm/kvm.c
> +++ b/arm/kvm.c
> @@ -169,9 +169,68 @@ bool kvm__arch_load_kernel_image(struct kvm
> *kvm, int fd_kernel, int fd_initrd, return true;
> }
>
> +static bool validate_fw_addr(struct kvm *kvm, u64 fw_addr)
> +{
> + u64 ram_phys;
> +
> + ram_phys = host_to_guest_flat(kvm, kvm->ram_start);
> +
> + if (fw_addr < ram_phys || fw_addr >= ram_phys +
> kvm->ram_size) {
I am OK with this check for now, but was wondering if we really *need*
to have the firmware in RAM? Couldn't we possibly put it into some
ROM/flash/nvmem device memory area and utilise XIP, for instance? I
understand that EDKII does not support this at the moment, but was just
thinking whether this would be an artificial restriction for other
firmware ports.
But I guess we can relax this later on, possibly when we support this
properly.
> + pr_err("Provide --firmware-address an address in
> RAM: "
> + "0x%016llx - 0x%016llx",
> + ram_phys, ram_phys + kvm->ram_size);
> +
> + return false;
> + }
> +
> + return true;
> +}
> +
> bool kvm__load_firmware(struct kvm *kvm, const char
> *firmware_filename) {
> - return false;
> + u64 fw_addr = kvm->cfg.arch.fw_addr;
> + void *host_pos;
> + void *limit;
> + ssize_t fw_sz;
> + int fd;
> +
> + limit = kvm->ram_start + kvm->ram_size;
> +
> + /* For default firmware address, lets load it at the
> begining of RAM */
> + if (fw_addr == 0)
> + fw_addr = ARM_MEMORY_AREA;
> +
> + if (!validate_fw_addr(kvm, fw_addr))
> + die("Bad firmware destination: 0x%016llx", fw_addr);
> +
> + fd = open(firmware_filename, O_RDONLY);
> + if (fd < 0)
> + return false;
> +
> + host_pos = guest_flat_to_host(kvm, fw_addr);
> + if (!host_pos || host_pos < kvm->ram_start)
> + return false;
> +
> + fw_sz = read_file(fd, host_pos, limit - host_pos);
> + if (fw_sz < 0)
> + die("failed to load firmware");
> + close(fd);
> +
> + /* Kernel isn't loaded by kvm, point start address to
> firmware */
> + kvm->arch.kern_guest_start = fw_addr;
> +
> + /* Load dtb just after the firmware image*/
> + host_pos += fw_sz;
> + if (host_pos + FDT_MAX_SIZE > limit)
> + die("not enough space to load fdt");
> +
> + kvm->arch.dtb_guest_start = ALIGN(host_to_guest_flat(kvm,
> host_pos),
> + FDT_ALIGN);
Does anyone know why we force a 2MB alignment (FDT_ALIGN) here? Will?
The DT spec and the ARM and arm64 kernel boot protocols just require an
8 byte alignment. So far this didn't really matter, but I guess the idea
is that the firmware picks up its dtb by looking just after its image
end (as U-Boot does, for instance). Forcing an additional 2MB alignment
sounds surprising and fragile here.
So is there any reason we can't reduce the alignment to the spec'ed 8
bytes?
On a related matter: I see that we still pass the DTB address in x0 (as
in the kernel boot protocol) and the EDKII port relies on this. Should
this be documented somewhere, then?
Apart from that the patch looks good to me.
Cheers,
Andre
> + pr_info("Placing fdt at 0x%llx - 0x%llx",
> + kvm->arch.dtb_guest_start,
> + kvm->arch.dtb_guest_start + FDT_MAX_SIZE);
> +
> + return true;
> }
>
> int kvm__arch_setup_firmware(struct kvm *kvm)
