On 1/9/19 2:08 PM, Michael Ellerman wrote: > Cédric Le Goater <clg@xxxxxxxx> writes: > >> These flags are shared between Linux/KVM implementing the hypervisor >> calls for the XIVE native exploitation mode and the driver for the >> sPAPR guests. >> >> Signed-off-by: Cédric Le Goater <clg@xxxxxxxx> >> --- >> arch/powerpc/include/asm/xive.h | 23 +++++++++++++++++++++++ >> arch/powerpc/sysdev/xive/spapr.c | 28 ++++++++-------------------- >> 2 files changed, 31 insertions(+), 20 deletions(-) >> >> diff --git a/arch/powerpc/include/asm/xive.h b/arch/powerpc/include/asm/xive.h >> index 3c704f5dd3ae..32f033bfbf42 100644 >> --- a/arch/powerpc/include/asm/xive.h >> +++ b/arch/powerpc/include/asm/xive.h >> @@ -93,6 +93,29 @@ extern void xive_flush_interrupt(void); >> /* xmon hook */ >> extern void xmon_xive_do_dump(int cpu); >> >> +/* >> + * Hcall flags shared by the sPAPR backend and KVM >> + */ >> + >> +/* H_INT_GET_SOURCE_INFO */ >> +#define XIVE_SPAPR_SRC_H_INT_ESB PPC_BIT(60) >> +#define XIVE_SPAPR_SRC_LSI PPC_BIT(61) >> +#define XIVE_SPAPR_SRC_TRIGGER PPC_BIT(62) >> +#define XIVE_SPAPR_SRC_STORE_EOI PPC_BIT(63) > > I have an (irrational) hatred of PPC_BIT, because it obfuscates what's > going on and makes PPC seem weirder than it needs to be. It could at > least be called IBM_BIT(). > > I know it helps people compare the code vs the documentation, but > basically no one has the documentation, and everyone has the code. > > Anyway it's not a show stopper, just a pet-peeve of mine :) Only the define matters, I can change that back to the non-PPC_BIT version in v2. Not a problem. Cheers, C.
