On Mon, Jan 07, 2019 at 08:19:26PM +0100, Michael Mueller wrote: > > On 03.01.19 15:43, Pierre Morel wrote: > >On 19/12/2018 20:17, Michael Mueller wrote: > >>This function processes the Gib Alert List (GAL). It is required > >>to run when either a gib alert interruption has been received or > >>a gisa that is in the alert list is cleared or dropped. > >> > >>The GAL is build up by millicode, when the respective ISC bit is > >>set in the Interruption Alert Mask (IAM) and an interruption of > >>that class is observed. > >> > >>Signed-off-by: Michael Mueller <mimu@xxxxxxxxxxxxx> > >>--- > >> arch/s390/kvm/interrupt.c | 140 > >>++++++++++++++++++++++++++++++++++++++++++++++ > >> 1 file changed, 140 insertions(+) > >> > >>diff --git a/arch/s390/kvm/interrupt.c b/arch/s390/kvm/interrupt.c > >>index 48a93f5e5333..03e7ba4f215a 100644 > >>--- a/arch/s390/kvm/interrupt.c > >>+++ b/arch/s390/kvm/interrupt.c > >>@@ -2941,6 +2941,146 @@ int kvm_s390_get_irq_state(struct kvm_vcpu > >>*vcpu, __u8 __user *buf, int len) > >> return n; > >> } > >> +static int __try_airqs_kick(struct kvm *kvm, u8 ipm) > > > >static inline ? Why? In general it is a good idea to leave it up to the compiler to decide if it is worth to inline a function or not, unless you have a good reason to force inlining.