On Mon, Jun 22, 2009 at 04:30:51PM +0300, Avi Kivity wrote: > On 06/18/2009 03:22 PM, Gleb Natapov wrote: >> Rearrange cpu loop to be (hopefully) more readable. Put difference >> between kernel/userspace irqchip in one place. >> >> >> static void flush_queued_work(CPUState *env) >> @@ -1877,6 +1871,8 @@ static void update_regs_for_init(CPUState *env) >> #endif >> >> cpu_reset(env); >> + /* cpu_reset() clears env->halted, cpu should be halted after init */ >> + env->halted = 1; >> > > How does that work for the boot cpu? void kvm_apic_init(CPUState *env) { if (env->cpu_index != 0) env->kvm_cpu_state.init = 1; kvm_update_interrupt_request(env); } Boot cpu does not get here. -- Gleb. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html