On Thu, 20 Dec 2018, Sean Christopherson wrote: > The -ftracer optimization was disabled in __noclone as a workaround to > GCC duplicating a blob of inline assembly that happened to define a > global variable. It has been pointed out that no amount of workarounds > can guarantee the compiler won't duplicate inline assembly[1], and that > disabling the -ftracer optimization has several unintended and nasty > side effects[2][3]. > > Now that the offending KVM code which required the workaround has > been properly fixed and no longer uses __noclone, remove the -ftracer > optimization tweak from __noclone. > > [1] https://lore.kernel.org/lkml/ri6y38lo23g.fsf@xxxxxxx/T/#u > [2] https://lore.kernel.org/lkml/20181218140105.ajuiglkpvstt3qxs@treble/T/#u > [3] https://patchwork.kernel.org/patch/8707981/#21817015 > > This reverts commit 95272c29378ee7dc15f43fa2758cb28a5913a06d. > > Suggested-by: Andi Kleen <ak@xxxxxxxxxxxxxxx> > Cc: Paolo Bonzini <pbonzini@xxxxxxxxxx> > Cc: Nadav Amit <namit@xxxxxxxxxx> > Cc: Andi Kleen <ak@xxxxxxxxxxxxxxx> > Cc: Josh Poimboeuf <jpoimboe@xxxxxxxxxx> > Cc: Martin Jambor <mjambor@xxxxxxx> > Cc: Arnd Bergmann <arnd@xxxxxxxx> > Cc: Steven Rostedt <rostedt@xxxxxxxxxxx> > Cc: Miroslav Benes <mbenes@xxxxxxx> > Signed-off-by: Sean Christopherson <sean.j.christopherson@xxxxxxxxx> with Miguel's change Reviewed-by: Miroslav Benes <mbenes@xxxxxxx> Miroslav
