On 21/12/18 11:06, Vitaly Kuznetsov wrote: >> Btw, I would prefer this without the >> >> default: break; >> >> as I don't think we'll ever add something there. > > "640K ought to be enough for anybody" :-) > > But in case you commit it as > > return index != MSR_IA32_MCG_EXT_CTL; > > I won't object. Thanks, Radim committed it as it, but I think he did want the switch statement (hey, vmx_has_emulated_msr has *two* cases!). It's just the "default: break;" that is unnecessary or could be "default: return true;". Paolo