Re: [kvm-unit-tests RFC v3 10/13] s390x: Add linemode buffer to fix newline on every print

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 18.12.18 13:41, Thomas Huth wrote:
> On 2018-12-18 10:26, Janosch Frank wrote:
>> Linemode seems to add a newline for each sent message which makes
>> reading rather hard. Hence we add a small buffer that and only print
>> if it's full or a newline is encountered.
>>
>> Signed-off-by: Janosch Frank <frankja@xxxxxxxxxxxxx>
>> ---
[...]
>>  /*
>>
> 
> That likely does not work as expected when someone is printing with the
> '\n' not being at the end (printf("Hello\nWor"); printf("ld\n");) ...
> but it's certainly better than before, so fine for me if you resend this
> the next time without RFC.
> 
>  Thomas
> 

It seems to print \n on a new line, at least it does on the SE operation
message consoles I work with. If not I would have gone mad by now, as I
print a lot of data with newlines for some new tests with "%lx\n %lx\n...".

I'll add a comment to the new function, to make clear why that's here.

Attachment: signature.asc
Description: OpenPGP digital signature


[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux