On Fri, Dec 14, 2018 at 11:31 AM Sean Christopherson <sean.j.christopherson@xxxxxxxxx> wrote: > > On Wed, Dec 12, 2018 at 04:10:26PM -0800, Jim Mattson wrote: > > If the guest supports RDTSCP, it already has read access to the > > hardware IA32_TSC_AUX MSR via RDTSCP, so we can allow it read-access > > via RDMSR as well. If the guest doesn't support RDTSCP, then we > > should not allow it read access to the hardware IA32_TSC_AUX MSR. > > Maybe tweak the last sentence? > > Intercept all accesses if the guest doesn't support RDTSCP in order > to inject #GP, IA32_TSC_AUX exists iff RDTSCP is supported. > > > Signed-off-by: Jim Mattson <jmattson@xxxxxxxxxx> > > Reviewed-by: Marc Orr <marcorr@xxxxxxxxxx> > > Reviewed-by: Peter Shier <pshier@xxxxxxxxxx> > > Reviewed-by: Sean Christopherson <sean.j.christopherson@xxxxxxxxx> Offline, Krish had a reasonable complaint about where I stuck this bit of code. Should I do another version with some refactoring, or are people happy enough with this version?
