Hi Radim, I love your patch! Yet something to improve: [auto build test ERROR on kvm/linux-next] [also build test ERROR on v4.20-rc6 next-20181213] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Radim-Kr-m/KVM-nSVM-improve-check-for-invalid-VMCB-guest-state/20181214-110547 base: https://git.kernel.org/pub/scm/virt/kvm/kvm.git linux-next config: x86_64-randconfig-x010-201849 (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 All errors (new ones prefixed by >>): arch/x86/kvm/svm.c: In function 'vmrun_interception': >> arch/x86/kvm/svm.c:3662:26: error: passing argument 1 of 'nested_vmcb_checks' from incompatible pointer type [-Werror=incompatible-pointer-types] if (!nested_vmcb_checks(svm)) ^~~ arch/x86/kvm/svm.c:3419:13: note: expected 'struct vmcb *' but argument is of type 'struct vcpu_svm *' static bool nested_vmcb_checks(struct vmcb *vmcb) ^~~~~~~~~~~~~~~~~~ cc1: some warnings being treated as errors vim +/nested_vmcb_checks +3662 arch/x86/kvm/svm.c 3650 3651 static int vmrun_interception(struct vcpu_svm *svm) 3652 { 3653 if (nested_svm_check_permissions(svm)) 3654 return 1; 3655 3656 /* Save rip after vmrun instruction */ 3657 kvm_rip_write(&svm->vcpu, kvm_rip_read(&svm->vcpu) + 3); 3658 3659 if (!nested_svm_vmrun(svm)) 3660 return 1; 3661 > 3662 if (!nested_vmcb_checks(svm)) 3663 goto failed; 3664 3665 if (!nested_svm_vmrun_msrpm(svm)) 3666 goto failed; 3667 3668 return 1; 3669 3670 failed: 3671 3672 svm->vmcb->control.exit_code = SVM_EXIT_ERR; 3673 svm->vmcb->control.exit_code_hi = 0; 3674 svm->vmcb->control.exit_info_1 = 0; 3675 svm->vmcb->control.exit_info_2 = 0; 3676 3677 nested_svm_vmexit(svm); 3678 3679 return 1; 3680 } 3681 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
Attachment:
.config.gz
Description: application/gzip
