Re: [PATCH v4 4/6] Documentation/vfio-mediated-device.txt: Update for vfio/mdev aggregation support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2018.12.11 10:58:01 -0700, Alex Williamson wrote:
> > +* <aggregation>
> > +
> > +  <aggregation> is an optional attributes to show max number that the
> > +  instance resources of [<type-id>] can be aggregated to be assigned
> > +  for one mdev device. No <aggregation> attribute means driver doesn't
> > +  support to aggregate instance resoures for one mdev device.
> > +  <aggregation> may be less than available_instances which depends on
> > +  driver. <aggregation> number can't exceed available_instances.
> 
> I wonder if this latter requirement is really necessary, it just seems
> to burden the vendor driver to make the aggregation attribute dynamic
> when it should seem pretty clear that a use cannot create a device with
> more instances than available.  We also lose a bit of introspection
> with this requirement, for example we don't really know how many
> instance can be aggregated unless it's less than the number of
> instances available.
>

True, it seems user should understand clearly that can't create more
instances than available, so don't really need to adjust aggregation
for that, which will also make the handling simpler. I'll update with
that.

Thanks

-- 
Open Source Technology Center, Intel ltd.

$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux