Jan Kiszka wrote: > Fix regression in CPU initialization caused by merge a5b526135d and try > to avoid this in the future by dropping qemu-kvm specific pc_new_cpu. If > such refactoring is desired, it should go through upstream first. F...ine. I'll write a hundred times: "Don't post while still compiling." Here is a version that only fixes the regression. -----------> Fix regression in CPU initialization caused by merge a5b526135d. Signed-off-by: Jan Kiszka <jan.kiszka@xxxxxxxxxxx> --- hw/pc.c | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/hw/pc.c b/hw/pc.c index 6c19f55..cb5b4d0 100644 --- a/hw/pc.c +++ b/hw/pc.c @@ -853,9 +853,6 @@ CPUState *pc_new_cpu(int cpu, const char *cpu_model, int pci_enabled) apic_init(env); } qemu_register_reset(main_cpu_reset, 0, env); - if (pci_enabled) { - apic_init(env); - } /* kvm needs this to run after the apic is initialized. Otherwise, * it can access invalid state and crash. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html