On Mon, Dec 10, 2018 at 01:54:18PM +0100, Vitaly Kuznetsov wrote: > Roman Kagan <rkagan@xxxxxxxxxxxxx> writes: > > Just noticed that the patch seems to assume that "direct" timers are > > allowed to use any vectors including 0-15. I guess this is incorrect, > > and instead stimer_set_config should error out on direct mode with a > > vector less than HV_SYNIC_FIRST_VALID_VECTOR. > > The spec is really vague about this and I'm not sure that this has > anything to do with HV_SYNIC_FIRST_VALID_VECTOR (as these are actually > not "synic" vectors, I *think* that SynIC doesn't even need to be > enabled to make them work). > > I checked and Hyper-V 2016 uses vector '0xff', not sure if it proves > your point :-) > > Do you envision any issues in KVM if we keep allowing vectors < > HV_SYNIC_FIRST_VALID_VECTOR? It's actually lapic that treats vectors 0..15 as illegal. Nothing Hyper-V specific here. Roman.
