On Mon, Dec 10, 2018 at 10:28:05AM +0000, Marc Zyngier wrote:
> On 10/12/2018 10:13, Christoffer Dall wrote:
> > On Thu, Dec 06, 2018 at 05:31:20PM +0000, Marc Zyngier wrote:
> >> diff --git a/virt/kvm/arm/arm.c b/virt/kvm/arm/arm.c
> >> index 23774970c9df..1db4c15edcdd 100644
> >> --- a/virt/kvm/arm/arm.c
> >> +++ b/virt/kvm/arm/arm.c
> >> @@ -1640,8 +1640,10 @@ int kvm_arch_init(void *opaque)
> >> return -ENODEV;
> >> }
> >>
> >> - if (!kvm_arch_check_sve_has_vhe()) {
> >> - kvm_pr_unimpl("SVE system without VHE unsupported. Broken cpu?");
> >> + in_hyp_mode = is_kernel_in_hyp_mode();
> >> +
> >> + if (!in_hyp_mode && kvm_arch_requires_vhe()) {
> >> + kvm_pr_unimpl("CPU requiring VHE was booted in non-VHE mode");
> >
> > nit: The error message feels weird to me (are we reporting CPU bugs?)
> > and I'm not sure about the unimpl and I think there's a linse space
> > missing.
> >
> > How about:
> >
> > kvm_err("Cannot support this CPU in non-VHE mode, not initializing\n");
>
> Yup, works for me. Will, do you mind changing this message for me?
I pushed out an updated branch here:
https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git/log/?h=kvm/cortex-a76-erratum-1165522
which should address all of Christoffer's comments and add his tags.
I plan to merge that into for-next/core later today.
Will
