Re: [PATCH 08/29] x86/fpu: Remove fpu->initialized usage in __fpu__restore_sig()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2018-12-06 21:07:22 [+0100], Borislav Petkov wrote:
> > @@ -314,41 +312,34 @@ static int __fpu__restore_sig(void __user *buf, void __user *buf_fx, int size)
> >  		 * thread's fpu state, reconstruct fxstate from the fsave
> >  		 * header. Validate and sanitize the copied state.
> >  		 */
> > +		union fpregs_state *state;
> > +		void *tmp;
> >  		struct user_i387_ia32_struct env;
> >  		int err = 0;
> 
> Sort those in reverse xmas order pls.
> 
> Otherwise looks ok.

You mean:
  		struct user_i387_ia32_struct env;
 +		union fpregs_state *state;
 +		void *tmp;
  		int err = 0;
?

Sebastian



[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux