Re: [kvm-unit-test 1/3] KVM nVMX: test_vmcs_page_* functions need to accept alignment size as a parameter

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 12/06/2018 11:55 AM, Jim Mattson wrote:
On Thu, Dec 6, 2018 at 10:46 AM Krish Sadhukhan
<krish.sadhukhan@xxxxxxxxxx> wrote:
.. because not all alignments fall on page size boundary.

Signed-off-by: Krish Sadhukhan <krish.sadhukhan@xxxxxxxxxx>
Reviewed-by: Mihai Carabas <mihai.carabas@xxxxxxxxxx>
But page references, by definition, do fall on a page size boundary.
If you're going to relax that constraint, perhaps you should drop
'page' from the function names?

Yes, I agree that we should drop 'page' from the names.  I propose test_vmcs_addr_*.



[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux