Re: [PATCH v4 07/10] KVM: s390: add function process_gib_alert_list()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 05.12.18 11:19, Halil Pasic wrote:
On Wed, 5 Dec 2018 10:57:33 +0100
Michael Mueller<mimu@xxxxxxxxxxxxx>  wrote:


On 05.12.18 10:09, Halil Pasic wrote:
On Fri, 30 Nov 2018 15:32:12 +0100
Michael Mueller<mimu@xxxxxxxxxxxxx>  wrote:

This function processes the gib alert list. It is required to
run when either a gib alert interruption has been received or
a gisa that might be in the alert list is cleared or dropped.

The GIB alert list contains all GISAs that have pending
adapter interruptions.
I'm not sure this last paragraph is 100% correct. If e.g. all vcpus
of a guest are in SIE we don't ask for alerting, and we would not get
alerted when an IPM bit is set in the GISA.

I will discard the "all" to make it 99.999% correct.

:). It ain't important. But discarding "all" helps only marginally. I
think we can have GISAs with IPM all zeros in the list. If I were to try
being constructive, I would propose something like: " The GIB alert list
contains GISAs of guests that may need a some vCPUS kicked
so their GISA interrupts can be delivered". But it really ain't
important. Feel free to keep it as is.

Sorry, I'm going to ignore this.




[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux