Re: [PATCH 1/7] KVM: nVMX: Prepend "nested_" to check_vmentry_{pre,post}reqs()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 12/03/2018 11:18 AM, Jim Mattson wrote:
On Fri, Nov 30, 2018 at 11:28 AM Krish Sadhukhan
<krish.sadhukhan@xxxxxxxxxx> wrote:
.. as they are used only in nested context.

Signed-off-by: Krish Sadhukhan <krish.sadhukhan@xxxxxxxxxx>
Reviewed-by: Liran Alon <liran.alon@xxxxxxxxxx>
Reviewed-by: Mihai Carabas <mihai.carabas@xxxxxxxxxx>
Reviewed-by: Mark Kanda <mark.kanda@xxxxxxxxxx>
I'm not sure what you mean by "nested context." That sounds to me like
"while running L2." However, these functions are only used while
running L1. There are many, many functions that fall into the category
of "L1 execution related to VMX emulation" that don't have a "nested"
prefix (e.g. the entire prepare_vmcs02* family). I don't think this
additional prefix actually helps to clarify anything.

I meant, "functions called for executing or for preparing to execute the nested guest".   prepare_vmcs02* family of functions identify themselves with a "vmcsXX" in their name while check_vmentry_{pre|post}reqs do not have any identification. It's just for better readability of the code.



[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux