On Mon, 3 Dec 2018 16:28:30 +0100 Michael Mueller <mimu@xxxxxxxxxxxxx> wrote: > On 03.12.18 10:43, Cornelia Huck wrote: > > On Fri, 30 Nov 2018 15:32:14 +0100 > > Michael Mueller <mimu@xxxxxxxxxxxxx> wrote: > >> @@ -2964,9 +2979,9 @@ void kvm_s390_gisa_init(struct kvm *kvm) > >> kvm->arch.gisa = &kvm->arch.sie_page2->gisa; > >> kvm->arch.iam = 0; > >> spin_lock_init(&kvm->arch.iam_ref_lock); > >> - VM_EVENT(kvm, 3, "gisa 0x%pK initialized", kvm->arch.gisa); > >> - kvm_s390_gisa_clear(kvm); > >> + nullify_gisa(kvm->arch.gisa); > > Why this change? The only difference here is that the unneeded check > > for gisa != NULL is not happening, and the dbf event for clearing is > > not logged? > > ... and the test if the gisa is in the alert list, which can't be the > case during its > initialization. Ok, so another optimization. We're only missing the extra dbf, which does not really give us extra info in this case. > > > > >> kvm->arch.gib_in_use = !!gib; > >> + VM_EVENT(kvm, 3, "gisa 0x%pK initialized", kvm->arch.gisa); > >> } > >> } > >>
