On Tue, 2009-06-16 at 07:05 -0400, Michael Goldish wrote: > ----- "Alexey Eromenko" <aeromenk@xxxxxxxxxx> wrote: > > > Michael I don't fully understand why shutdown test is needed; Shutdown > > is tested during reboot, where GuestOS must de-init itself. > > The main motivation for a shutdown test is that it allows us to choose > whether VMs should be kept alive after the last test. Including this test > in a job takes no more time than running the job without it, because > normally the preprocessor automatically shuts down guests (except for the > last one). > > There's also a small difference between a complete shutdown and a reboot -- > a shutdown is supposed to close the qemu process. I'm not sure this > difference justifies the test, but the reason mentioned in the previous > paragraph does, in my opinion. Fair enough, I agree. Will apply the patch. -- Lucas Meneghel Rodrigues Software Engineer (QE) Red Hat - Emerging Technologies -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html