On Wed, 28 Nov 2018 15:57:53 +0000 "Moger, Babu" <Babu.Moger@xxxxxxx> wrote: > My bad.. Sorry about this. I think this should also go to > stable@xxxxxxxxxxxxxxx No problem man, this happens. Thanks for the review! > > > -----Original Message----- > > From: Luiz Capitulino <lcapitulino@xxxxxxxxxx> > > Sent: Friday, November 23, 2018 12:27 PM > > To: Liran Alon <liran.alon@xxxxxxxxxx> > > Cc: Paolo Bonzini <pbonzini@xxxxxxxxxx>; Moger, Babu > > <Babu.Moger@xxxxxxx>; kvm@xxxxxxxxxxxxxxx; linux- > > kernel@xxxxxxxxxxxxxxx > > Subject: Re: [PATCH] KVM: VMX: re-add ple_gap module parameter > > > > On Fri, 23 Nov 2018 19:42:53 +0200 > > Liran Alon <liran.alon@xxxxxxxxxx> wrote: > > > > > > On 23 Nov 2018, at 19:02, Luiz Capitulino <lcapitulino@xxxxxxxxxx> > > wrote: > > > > > > > > > > > > Apparently, the ple_gap parameter was accidentally removed > > > > by commit c8e88717cfc6b36bedea22368d97667446318291. Add it > > > > back. > > > > > > > > Signed-off-by: Luiz Capitulino <lcapitulino@xxxxxxxxxx> > > > > > > Weird that nobody noticed this when patch was applied… Thanks. > > > Reviewed-by: Liran Alon <liran.alon@xxxxxxxxxx> > Reviewed-by: Babu Moger <babu.moger@xxxxxxx> > > > > > I forgot to mention that I noticed this because I have systems > > disabling ple with ple_gap=0 in modprobe.conf. In those systems > > kvm_intel won't load anymore. > > > > > > > > > --- > > > > arch/x86/kvm/vmx.c | 1 + > > > > 1 file changed, 1 insertion(+) > > > > > > > > diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c > > > > index 4555077d69ce..be6f13f1c25f 100644 > > > > --- a/arch/x86/kvm/vmx.c > > > > +++ b/arch/x86/kvm/vmx.c > > > > @@ -174,6 +174,7 @@ module_param_named(preemption_timer, > > enable_preemption_timer, bool, S_IRUGO); > > > > * refer SDM volume 3b section 21.6.13 & 22.1.3. > > > > */ > > > > static unsigned int ple_gap = KVM_DEFAULT_PLE_GAP; > > > > +module_param(ple_gap, uint, 0444); > > > > > > > > static unsigned int ple_window = KVM_VMX_DEFAULT_PLE_WINDOW; > > > > module_param(ple_window, uint, 0444); > > > > -- > > > > 2.17.2 > > > > > > > >
