Re: [RFC PATCH v4 05/13] workqueue, ktask: renice helper threads to prevent starvation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [RFC PATCH v4 05/13] workqueue, ktask: renice helper threads to prevent starvation
From: Tejun Heo <tj@xxxxxxxxxx>
Date: Tue, 20 Nov 2018 08:33:19 -0800
Cc: linux-mm@xxxxxxxxx, kvm@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, aarcange@xxxxxxxxxx, aaron.lu@xxxxxxxxx, akpm@xxxxxxxxxxxxxxxxxxxx, alex.williamson@xxxxxxxxxx, bsd@xxxxxxxxxx, darrick.wong@xxxxxxxxxx, dave.hansen@xxxxxxxxxxxxxxx, jgg@xxxxxxxxxxxx, jwadams@xxxxxxxxxx, jiangshanlai@xxxxxxxxx, mhocko@xxxxxxxxxx, mike.kravetz@xxxxxxxxxx, Pavel.Tatashin@xxxxxxxxxxxxx, prasad.singamsetty@xxxxxxxxxx, rdunlap@xxxxxxxxxxxxx, steven.sistare@xxxxxxxxxx, tim.c.chen@xxxxxxxxx, vbabka@xxxxxxx
In-reply-to: <20181119164554.axobolrufu26kfah@ca-dmjordan1.us.oracle.com>
References: <20181105165558.11698-1-daniel.m.jordan@oracle.com> <20181105165558.11698-6-daniel.m.jordan@oracle.com> <20181113163400.GK2509588@devbig004.ftw2.facebook.com> <20181119164554.axobolrufu26kfah@ca-dmjordan1.us.oracle.com>
User-agent: Mutt/1.5.21 (2010-09-15)

On Mon, Nov 19, 2018 at 08:45:54AM -0800, Daniel Jordan wrote:
> So instead of flush_work_at_nice, how about this?:
> 
> void renice_work_sync(work_struct *work, long nice);

Wouldn't renice_or_cancel make more sense?

Thanks.

-- 
tejun

Follow-Ups:
- Re: [RFC PATCH v4 05/13] workqueue, ktask: renice helper threads to prevent starvation
  - From: Daniel Jordan

References:
- [RFC PATCH v4 00/13] ktask: multithread CPU-intensive kernel work
  - From: Daniel Jordan
- [RFC PATCH v4 05/13] workqueue, ktask: renice helper threads to prevent starvation
  - From: Daniel Jordan
- Re: [RFC PATCH v4 05/13] workqueue, ktask: renice helper threads to prevent starvation
  - From: Tejun Heo
- Re: [RFC PATCH v4 05/13] workqueue, ktask: renice helper threads to prevent starvation
  - From: Daniel Jordan

Prev by Date: Re: [PATCH v2 2/5] util: introduce threaded workqueue
Next by Date: Re: [RFC PATCH v4 05/13] workqueue, ktask: renice helper threads to prevent starvation
Previous by thread: Re: [RFC PATCH v4 05/13] workqueue, ktask: renice helper threads to prevent starvation
Next by thread: Re: [RFC PATCH v4 05/13] workqueue, ktask: renice helper threads to prevent starvation
Index(es):
- Date
- Thread

[Index of Archives] [KVM ARM] [KVM ia64] [KVM ppc] [Virtualization Tools] [Spice Development] [Libvirt] [Libvirt Users] [Linux USB Devel] [Linux Audio Users] [Yosemite Questions] [Linux Kernel] [Linux SCSI] [XFree86]