On Thu, Nov 15, 2018 at 12:45:48AM -0500, Krish Sadhukhan wrote:
> v1 -> v2:
> The re-organization of the checks in check_vmentry_prereqs() has now
> been done based on the ordering of the checks in the chapter
> "Basic VM-Entry Checks" in Intel SDM vol 3C.
Nit: technically it's the "VM Entries" chapter, "Basic VM-Entry Checks"
is a subsection that covers the checks that occur before the user-defined
fields are processed.
> [PATCH v2 1/6] nVMX x86: Re-name check_vmentry_pre[post]reqs to
> [PATCH v2 2/6] nVMX x86: Re-organize the code in
> [PATCH v2 3/6] nVMX x86: Re-organize the code in
> [PATCH v2 4/6] nVMX x86: Re-organize the code in
> [PATCH v2 5/6] nVMX x86: Re-organize the code in
> [PATCH v2 6/6] nVMX x86: Re-organize the code in
The subject prefix for all patches should be 'KVM: nVMX'.
For patches 2-6, the subjects aren't very helpful as they don't decribe
the actually change very well, i.e. "re-organize" makes it sound like
the code is simply being refactored in the existing function, and naming
the existing function only reinforces this notion.
It'd also be helpful to call out which fields/checks are being touched
earlier in the subject, e.g. the above logs all get trimmed to the same
"Re-organize the code in" subject.
Maybe a template like this for the changelogs?
KVM: nVMX: Move VM-Exit Controls checks to separate helper function
... to improve readability and maintainability, and to align the code
with the layout of the "VM Entries" chapter in Intel's SDM.
> arch/x86/kvm/vmx.c | 155 ++++++++++++++++++++++++++++++++++-------------------
> 1 file changed, 100 insertions(+), 55 deletions(-)
>
> Krish Sadhukhan (6):
> nVMX x86: Re-name check_vmentry_pre[post]reqs to nested_check_vmentry_pre[post]reqs
> nVMX x86: Re-organize the code in nested_check_vmentry_prereqs(), that are related to VM-Execution Control Fields
> nVMX x86: Re-organize the code in check_vmentry_prereqs(), that are related to VM-Exit Control Fields
> nVMX x86: Re-organize the code in nested_check_vmentry_prereqs(), that are related to VM-Entry Control Fields
> nVMX x86: Re-organize the code in nested_check_vmentry_prereqs(), that are related to Host Control Registers and MSRs
> nVMX x86: Re-organize the code in nested_check_vmentry_prereqs(), related to Guest Non-Register State
