On Tue, 2009-06-16 at 14:00 +0300, Michael Goldish wrote: > This is intended to save disk space. Requires ImageMagick (uses mogrify). > > To enable: > convert_ppm_files_to_png = yes > > To enable only for failed tests: > convert_ppm_files_to_png_on_error = yes > > Reminder: by default PPM files are removed after the test (and after the > conversion, if requested). To keep them specify: > keep_ppm_files = yes > > To keep them only for failed tests: > keep_ppm_files_on_error = yes > > A reasonable choice would be to keep PNG files for failed tests, and never > keep PPM files. To do this specify > convert_ppm_files_to_png_on_error = yes > without specifying 'keep_ppm_files = yes' or 'keep_ppm_files_on_error = yes' > (or explicitly set to 'no', if it was set to 'yes' on a higher level in the > config hierarchy). > > This patch also makes small cosmetic changes to the 'keep_ppm_files' feature. Forgot to say that other than performing a check to see if we actually do have ImageMagick before trying to convert the images, the patch series looks good, once you get this worked out I am going to apply it. -- Lucas Meneghel Rodrigues Software Engineer (QE) Red Hat - Emerging Technologies -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
