On 06/11/2018 01:55, Luwei Kang wrote: > Get fixed PMC is unnecessary if fixed counter configuration > have no changed in KVM Guest. > > Signed-off-by: Luwei Kang <luwei.kang@xxxxxxxxx> > --- > arch/x86/kvm/pmu_intel.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/arch/x86/kvm/pmu_intel.c b/arch/x86/kvm/pmu_intel.c > index 5ab4a36..f896462 100644 > --- a/arch/x86/kvm/pmu_intel.c > +++ b/arch/x86/kvm/pmu_intel.c > @@ -44,11 +44,10 @@ static void reprogram_fixed_counters(struct kvm_pmu *pmu, u64 data) > u8 old_ctrl = fixed_ctrl_field(pmu->fixed_ctr_ctrl, i); > struct kvm_pmc *pmc; > > - pmc = get_fixed_pmc(pmu, MSR_CORE_PERF_FIXED_CTR0 + i); > - > if (old_ctrl == new_ctrl) > continue; > > + pmc = get_fixed_pmc(pmu, MSR_CORE_PERF_FIXED_CTR0 + i); > reprogram_fixed_counter(pmc, new_ctrl, i); > } More of a cleanup, since the compiler should be able to do this alone, but I'll queue it. Paolo
