On Thu, 2018-10-25 at 09:55 -0700, Jim Mattson wrote: > Looking at the second asm statement and the comment that precedes it, > my first question would be, "What about the registers not covered > here?" Good point. I'll make the comment a bit clearer. > I'm also not convinced that the register-clearing asm statement > is actually "clearer" with some registers cleared as input arguments > and others cleared explicitly, but otherwise, the change looks fine > to > me. The inline assembly itself may not be clearer, but it has a single purpose now. You are free to ignore it if you want to change aspects of the VM entry path. It almost fits on a single screen now. ;) > > Reviewed-by: Jim Mattson <jmattson@xxxxxxxxxx> Thanks! Julian Amazon Development Center Germany GmbH Berlin - Dresden - Aachen main office: Krausenstr. 38, 10117 Berlin Geschaeftsfuehrer: Dr. Ralf Herbrich, Christian Schlaeger Ust-ID: DE289237879 Eingetragen am Amtsgericht Charlottenburg HRB 149173 B