Re: [PATCH] KVM/nVMX: Remove uneeded forward jump in nested_vmx_check_vmentry_hw asm

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Oct 23, 2018 at 11:26 PM Krish Sadhukhan
<krish.sadhukhan@xxxxxxxxxx> wrote:
>
>
>
> On 10/22/2018 03:09 PM, Uros Bizjak wrote:
> > There is no need to jump just after the jump insn itself. Also, make
> > code similar to entering guest mode in vmx_vcpu_run.
> >
> > Signed-off-by: Uros Bizjak <ubizjak@xxxxxxxxx>
> > ---
> >   arch/x86/kvm/vmx.c | 8 +++-----
> >   1 file changed, 3 insertions(+), 5 deletions(-)
> >
> > diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
> > index 641a65b30685..5600a01fa6d7 100644
> > --- a/arch/x86/kvm/vmx.c
> > +++ b/arch/x86/kvm/vmx.c
> > @@ -13240,13 +13240,11 @@ static int __noclone nested_vmx_check_vmentry_hw(struct kvm_vcpu *vcpu)
> >
> >               /* Check if vmlaunch of vmresume is needed */
>
> Not a big deal, but would you mind fixing the comment ?

I dont't like mixing whitespace/comment/whatever fixes with functional
changes in the same patch. OTOH, I'm sure somebody is thrilling with
the idea to fix this comment and the original one in vmx_vcpu_run.

BR,
Uros.



[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux