RE: [kvm-unit-tests PATCH] x86: svm: Fix incorrect ordering within struct regs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Gentle ping.

We want to upstream a patch testing all MSRs interceptable by SVM.

Without this fix, the values of registers RCX & RDX used by the instructions RDMSR & WRMSR cannot be inspected after #VMEXIT using "struct regs".

Regards,
William

> -----Original Message-----
> From: kvm-owner@xxxxxxxxxxxxxxx <kvm-owner@xxxxxxxxxxxxxxx> On Behalf Of Tambe, William
> Sent: Monday, October 15, 2018 3:46 PM
> To: kvm@xxxxxxxxxxxxxxx
> Subject: [kvm-unit-tests PATCH] x86: svm: Fix incorrect ordering within struct regs
> 
> "struct regs" is used within x86/svm.c to describe
> the memory region where SAVE_GPR_C saves registers.
> 
> The ordering within "struct regs" must be corrected
> so that it matches how SAVE_GPR_C stores registers.
> 
> Signed-off-by: William Tambe <william.tambe@xxxxxxx>
> ---
>  x86/svm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/x86/svm.c b/x86/svm.c
> index 701ab2f..bc0396d 100644
> --- a/x86/svm.c
> +++ b/x86/svm.c
> @@ -199,9 +199,9 @@ static void test_thunk(struct test *test)
> 
>  struct regs {
>          u64 rax;
> +        u64 rbx;
>          u64 rcx;
>          u64 rdx;
> -        u64 rbx;
>          u64 cr2;
>          u64 rbp;
>          u64 rsi;
> --
> 2.17.1





[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux