On 10/18/2018 09:48 AM, Andy Lutomirski wrote: >>>> We might want to do this for cleanliness reasons... Maybe. >>>> >>>> But this *should* have no practical effects. Kernel threads have no >>>> real 'mm' and no user pages. They should not have do access to user >>>> mappings. Protection keys *only* apply to user mappings. Thus, >>>> logically, they should never be affected by PKRU values. >>>> >>>> So I'm kinda missing the point of the patch. >>> use_mm(). >> So. I would drop that patch from queue. Anyone feels different about it? >> > I think we *do* want the patch. It’s a bugfix for use_mm users, right? Yes, we need it. I was being dense and Andy kindly reminded me of the point of the patch.