On Thu, 26 Jul 2018, Luwei Kang wrote: > From: Chao Peng <chao.p.peng@xxxxxxxxxxxxxxx> > > Intel Processor Trace virtualization enabling in KVM guest > need to access these MSRs bit definitions, so move them to > public header file msr-index.h. I had to read this more than once to grok it. May I suggest to reword it slightly: perf/x86/intel/pt: Move Intel PT MSRs bit defines to global header The Intel Processor Trace (PT) MSR bit defines are in a private header. The upcoming support for PT virtualization requires these defines to be accessible from KVM code. Move them to the global MSR header file. Other than that: Reviewed-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>