On Wed, Oct 10, 2018 at 05:05:26PM +0800, Zhenyu Wang wrote: > On 2018.09.25 12:23:56 -0600, Alex Williamson wrote: > > On Fri, 21 Sep 2018 10:30:11 +0200 > > Gerd Hoffmann <kraxel@xxxxxxxxxx> wrote: > > > > > Update vfio api, adapt mbochs sample driver. > > > > > > v3: refine vfio region layout, improve documentation. > > > v2: try vfio region approach. > > > > > > Gerd Hoffmann (2): > > > vfio: add edid api for display (vgpu) devices. > > > vfio: add edid support to mbochs sample driver > > > > > > include/uapi/linux/vfio.h | 50 +++++++++++++++++ > > > samples/vfio-mdev/mbochs.c | 136 ++++++++++++++++++++++++++++++++++++++------- > > > 2 files changed, 167 insertions(+), 19 deletions(-) > > > > > > > This looks good to me, but I'm not clear if the discussion about pixel > > clocks fully ran its course. Zhenyu, are you satisfied GVT-g can work > > within this interface? Any comments from NVIDIA? Thanks, > > > > For current vfio gfx, I think this is fine. For really limited HW > that might have clock gap, we could skip edid region support on it. > > I'm not sure if we'd like to extend it for multiple display support? > As it seems edid blob definition is self-contained, maybe we'll only > have some region index reference added? We do not have multiple display support in the vfio display api anyway. cheers, Gerd