On 08/10/2018 19:32, Borislav Petkov wrote: > On Mon, Oct 08, 2018 at 02:52:46PM +0000, Singh, Brijesh wrote: >> Does it make sense to move all the SEV specific code in svm-sev.c ? >> I am looking to add SEV migration support very soon, and can see >> myself adding more SEV command handling which will grow svm.c further. > > Amen to that - svm.c is pretty huge already. And if you end up moving > facilities, you can simply call it sev.c Creating arch/x86/kvm/{mmu,vmx,svm}/ has been on my todo list for a while. If you would like to split the SEV bits, that would be a good start. Paolo