Re: [PATCH 1/4] KVM: nVMX: Flush TLB entries tagged by dest EPTP on L1<->L2 transitions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 07/10/2018 22:36, Liran Alon wrote:
>>>
>>> To achieve this, instead of directly calling vmx_flush_tlb() we request
>>> it to be called by KVM_REQ_TLB_FLUSH which is evaluated after
>>> KVM_REQ_LOAD_CR3 which sets the active_eptp to EPTP02 as required.
>>>
>>> Similarly, on L2->L1 VMExit, active EPTP is EPTP02 but TLB entries
>>> populated by L1 are tagged with EPTP01 and therefore we should delay
>>> vmx_flush_tlb() until active_eptp is EPTP01.
>>>
>> Fixes: 6e42782f516f05c8030f63308f2457681b1c9919
>>
>> Queued, thanks.
>>
>> Paolo
> I don’t see how this patch fixes 6e42782f516f05c8030f63308f2457681b1c9919.

Indeed, I mistakenly thought that the flush was after kvm_mmu_load of
the nested EPT context (so that patch would have put it afterwards), but
it is actually the TLB flush that comes first.

Paolo



[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux