On Fri, 5 Oct 2018 10:57:22 +0200 Pierre Morel <pmorel@xxxxxxxxxxxxx> wrote: > On 05/10/2018 10:49, Cornelia Huck wrote: > > On Fri, 5 Oct 2018 10:31:09 +0200 > > Pierre Morel <pmorel@xxxxxxxxxxxxx> wrote: > > > >> kvm_arch_crypto_set_masks is a new function to centralize > >> the setup the APCB masks inside the CRYCB SIE satelite. > > > > s/satelite/satellite/ > > > >> > >> To trace APCB mask changes, we add KVM_EVENT() tracing to > >> both kvm_arch_crypto_set_masks and kvm_arch_crypto_clear_masks. > >> > >> Signed-off-by: Pierre Morel <pmorel@xxxxxxxxxxxxx> > >> --- > >> arch/s390/include/asm/kvm_host.h | 2 ++ > >> arch/s390/kvm/kvm-s390.c | 41 ++++++++++++++++++++++++++++++++++++++++ > >> 2 files changed, 43 insertions(+) (...) > > The locking and requests makes me wonder if we missed them before... > > were they simply not needed for the prior use case (mdev group > > notifier)? > > Before we used to set the mask before creating the vcpu. > In fact since we still call this function from the initialization > of VFIO AP we still do. > > But since this function is more generic we need to be more careful > if it is called when vcpu are running. > We do the same locking mechanism in the kvm_arch_crypto_clear_mask(). Yes, that makes sense. Reviewed-by: Cornelia Huck <cohuck@xxxxxxxxxx>
