On 03/10/2018 20:39, Sean Christopherson wrote: >>> - if (!cpu_has_vmx_flexpriority() && >>> + if (!flexpriority_enabled && >>> !cpu_has_vmx_virtualize_x2apic_mode()) >>> return; >> I think it would be better if cpu_has_vmx_flexpriority() returned >> false when flexpriority_enabled is false. > Ha, I had that all coded up but decided against it because the > convention used by other module params is to not adjust cpu_has_*(). Yeah, for now let's stick to the minimum. It's a common idiom to adjust the variable instead of the cpu_has_*() because then the processor capabilities show up in /sys/kernel/module/kvm_intel/parameters. It requires more care but it's also more user friendly. Paolo
