On Mon, Oct 1, 2018 at 2:25 PM, Sean Christopherson
<sean.j.christopherson@xxxxxxxxx> wrote:
> Return early from vmx_set_virtual_apic_mode() if the processor doesn't
> support VIRTUALIZE_APIC_ACCESSES or VIRTUALIZE_X2APIC_MODE, both of
> which reside in SECONDARY_VM_EXEC_CONTROL. This eliminates warnings
> due to VMWRITEs to SECONDARY_VM_EXEC_CONTROL (VMCS field 401e) failing
> on processors without secondary exec controls.
>
> Remove the similar check for TPR shadowing as it is incorported in the
> cpu_has_vmx_flexpriority() check and the APIC-related code in
> vmx_update_msr_bitmap() is further gated by VIRTUALIZE_X2APIC_MODE.
>
> Reported-by: Gerhard Wiesinger <redhat@xxxxxxxxxxxxx>
> Fixes: 8d860bbeedef ("kvm: vmx: Basic APIC virtualization controls have three settings")
> Cc: Jim Mattson <jmattson@xxxxxxxxxx>
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Sean Christopherson <sean.j.christopherson@xxxxxxxxx>
In the context of part 1...
Reviewed-by: Jim Mattson <jmattson@xxxxxxxxxx>
