On 9/28/2018 11:17 AM, Gerd Hoffmann wrote: > Hi, > >>> This looks good to me, but I'm not clear if the discussion about pixel >>> clocks fully ran its course. Zhenyu, are you satisfied GVT-g can work >>> within this interface? Any comments from NVIDIA? Thanks, >> >> As of now, default edid with basic modes is provided with NVIDIA driver, >> so don't have such requirement. > > The advantage would be that the default mode can be changed, so the host > can give a hint to the guest which of the video modes should be used. > > The qemu test branch[1] adds xres and yres properties as showcase, i.e. > you can use -device vfio-pci,xres=1280,yres=900,... > >> As I understand, if VFIO_REGION_SUBTYPE_GFX_EDID region is not provided >> by vendor driver, console vnc should work as it is now. > > Yes, the region is optional. > Ok. Looks good to me. Just add comment as I mentioned in other mail. Thanks, Kirti > cheers, > Gerd > > [1] https://git.kraxel.org/cgit/qemu/log/?h=sirius/edid-vfio >
